Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Special Number-2 Calculator #1566

Closed
wants to merge 2 commits into from
Closed

Added Special Number-2 Calculator #1566

wants to merge 2 commits into from
+252 −0

Conversation

shreya-paul-17
Copy link
Contributor

@shreya-paul-17 shreya-paul-17 commented Jul 7, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #1282

Description👨‍💻

Special Number calculator added

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

ss-5

@netlify Netlify
Copy link

netlify bot commented Jul 7, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit b743ff1
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/668a86b021664a0008cd84da
😎 Deploy Preview https://deploy-preview-1566--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Jul 7, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @shreya-paul-17, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Nihal4777
Copy link

@shreya-paul-17 Please add empty field validations.
image

@Rakesh9100
Copy link
Owner

Are you working @shreya-paul-17

@shreya-paul-17
Copy link
Contributor Author

shreya-paul-17 commented Jul 14, 2024 •
edited
Loading

@Rakesh9100, @Nihal4777 another person has included a special number calculator but with a different logic. It is continuously conflicting with my files. How to resolve these?

@Rakesh9100
Copy link
Owner

You can rename your calculator folder to Special-Number-2-Calculator and make the necessary changes by making the new commits in this same PR @shreya-paul-17

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jul 14, 2024
@Rakesh9100 Rakesh9100 changed the title Special Number Calculator added Added Special Number-2 Calculator Jul 14, 2024
@shreya-paul-17
Copy link
Contributor Author

shreya-paul-17 commented Jul 16, 2024 •
edited
Loading

There were some issues that were still existing in the current branch. So I created a new branch. Thus I created a new PR #1659 . @Rakesh9100 please check that PR and kindly close this PR if the new PR is not having any problems with merging to the main branch of the base repo.

@Rakesh9100 Rakesh9100 closed this Jul 29, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Add Special Number-2 Calculator
3 participants
@shreya-paul-17 @Nihal4777 @Rakesh9100